fix: change enums usage to work on all supported python versions #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't run integration tests on python 3.12 in CI and this issue occurred only in this specific version. We should consider adding test runs for more python versions. (I tried adding it here but there was some python 3.12 caching issue, so I decided it would be better to add with a separate issue). Here are screens from local neo4j tests run
|
This reverts commit 7de281c.
| @@ -122,4 +122,5 @@ jobs: | |||
| make install-base | |||
| make install-test | |||
| pip install unstructured | |||
| python -c "from unstructured.nlp.tokenize import download_nltk_packages; download_nltk_packages()" | |||
There was a problem hiding this comment.
Added it because there was an error with nltk packages being not available
mpolomdeepsense
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class derived from
strandEnumdid not behave as expected in python 3.12. Changed usage to work with all supported versions.